Rename kibana_overview to opensearch_dashboards_overview plugin (#37) #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
mihirsoni
reviewed
Mar 11, 2021
mihirsoni
reviewed
Mar 11, 2021
src/plugins/opensearch_dashboards_overview/public/application.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
src/plugins/opensearch_dashboards_overview/public/application.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
src/plugins/opensearch_dashboards_overview/public/application.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
src/plugins/opensearch_dashboards_overview/public/application.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
src/plugins/opensearch_dashboards_overview/public/components/add_data/add_data.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
src/plugins/opensearch_dashboards_overview/public/components/add_data/add_data.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
...ns/opensearch_dashboards_overview/public/components/getting_started/getting_started.test.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
...ns/opensearch_dashboards_overview/public/components/getting_started/getting_started.test.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
...ns/opensearch_dashboards_overview/public/components/getting_started/getting_started.test.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
...ns/opensearch_dashboards_overview/public/components/getting_started/getting_started.test.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
...plugins/opensearch_dashboards_overview/public/components/getting_started/getting_started.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
...plugins/opensearch_dashboards_overview/public/components/getting_started/getting_started.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
src/plugins/opensearch_dashboards_overview/public/components/manage_data/manage_data.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
src/plugins/opensearch_dashboards_overview/public/components/overview/overview.test.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
src/plugins/opensearch_dashboards_overview/public/components/overview/overview.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
src/plugins/opensearch_dashboards_overview/public/components/overview/overview.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 11, 2021
src/plugins/opensearch_dashboards_overview/public/components/overview/overview.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
ananzh
reviewed
Mar 12, 2021
ananzh
previously requested changes
Mar 12, 2021
ananzh
reviewed
Mar 12, 2021
| @@ -49,9 +49,9 @@ const mockNewsFetchResult = { | |||
| hash: '8e18fcedbc', | |||
| linkText: 'Read more on the blog', | |||
| linkUrl: | |||
| 'https://www.elastic.co/blog/the-go-client-for-elasticsearch-introduction?blade=kibanafeed', | |||
| 'https://www.elastic.co/blog/the-go-client-for-elasticsearch-introduction?blade=opensearchdashboardsfeed', | |||
There was a problem hiding this comment.
kibanafeed -->opensearchDashboardsfeed
There was a problem hiding this comment.
This doesn't matter anyways since it will be a dead link
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
ananzh
approved these changes
Mar 12, 2021
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
… (#155) * Rename kibana_overview to opensearch_dashboards_overview plugin (#37) Signed-off-by: Bishoy Boktor <boktorbb@amazon.com> * Address PR comments Signed-off-by: Bishoy Boktor <boktorbb@amazon.com> * Address PR comments Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2023
* feat: add self host runner * feat: update * feat: update * feat: update * feat: use v4 * feat: update * Revert "feat: use v4" This reverts commit fc24867. * feat: use auto-scaleable runners * feat: use sudo * feat: update --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bishoy Boktor boktorbb@amazon.com