-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename kibana_overview to opensearch_dashboards_overview plugin (#37) #155
Rename kibana_overview to opensearch_dashboards_overview plugin (#37) #155
Conversation
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
src/plugins/opensearch_dashboards_overview/public/application.tsx
Outdated
Show resolved
Hide resolved
src/plugins/opensearch_dashboards_overview/public/application.tsx
Outdated
Show resolved
Hide resolved
src/plugins/opensearch_dashboards_overview/public/application.tsx
Outdated
Show resolved
Hide resolved
src/plugins/opensearch_dashboards_overview/public/application.tsx
Outdated
Show resolved
Hide resolved
src/plugins/opensearch_dashboards_overview/public/components/add_data/add_data.tsx
Outdated
Show resolved
Hide resolved
src/plugins/opensearch_dashboards_overview/public/components/add_data/add_data.tsx
Outdated
Show resolved
Hide resolved
...ns/opensearch_dashboards_overview/public/components/getting_started/getting_started.test.tsx
Outdated
Show resolved
Hide resolved
...ns/opensearch_dashboards_overview/public/components/getting_started/getting_started.test.tsx
Outdated
Show resolved
Hide resolved
...ns/opensearch_dashboards_overview/public/components/getting_started/getting_started.test.tsx
Outdated
Show resolved
Hide resolved
...ns/opensearch_dashboards_overview/public/components/getting_started/getting_started.test.tsx
Outdated
Show resolved
Hide resolved
...plugins/opensearch_dashboards_overview/public/components/getting_started/getting_started.tsx
Outdated
Show resolved
Hide resolved
...plugins/opensearch_dashboards_overview/public/components/getting_started/getting_started.tsx
Outdated
Show resolved
Hide resolved
src/plugins/opensearch_dashboards_overview/public/components/manage_data/manage_data.tsx
Outdated
Show resolved
Hide resolved
src/plugins/opensearch_dashboards_overview/public/components/overview/overview.test.tsx
Outdated
Show resolved
Hide resolved
src/plugins/opensearch_dashboards_overview/public/components/overview/overview.tsx
Outdated
Show resolved
Hide resolved
src/plugins/opensearch_dashboards_overview/public/components/overview/overview.tsx
Outdated
Show resolved
Hide resolved
src/plugins/opensearch_dashboards_overview/public/components/overview/overview.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor issue of extra space:
public stop() {} is now public stop() { }
Others all good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@@ -49,9 +49,9 @@ const mockNewsFetchResult = { | |||
hash: '8e18fcedbc', | |||
linkText: 'Read more on the blog', | |||
linkUrl: | |||
'https://www.elastic.co/blog/the-go-client-for-elasticsearch-introduction?blade=kibanafeed', | |||
'https://www.elastic.co/blog/the-go-client-for-elasticsearch-introduction?blade=opensearchdashboardsfeed', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibanafeed -->opensearchDashboardsfeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't matter anyways since it will be a dead link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But fixed
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
… (#155) * Rename kibana_overview to opensearch_dashboards_overview plugin (#37) Signed-off-by: Bishoy Boktor <boktorbb@amazon.com> * Address PR comments Signed-off-by: Bishoy Boktor <boktorbb@amazon.com> * Address PR comments Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
* feat: add self host runner * feat: update * feat: update * feat: update * feat: use v4 * feat: update * Revert "feat: use v4" This reverts commit fc24867. * feat: use auto-scaleable runners * feat: use sudo * feat: update --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Bishoy Boktor boktorbb@amazon.com